Run rsync with project as working directory#49
Closed
enykeev wants to merge 1 commit intodingjie:masterfrom
Closed
Run rsync with project as working directory#49enykeev wants to merge 1 commit intodingjie:masterfrom
enykeev wants to merge 1 commit intodingjie:masterfrom
Conversation
Author
|
Personally, I'm planning to use it with vagrant. Instead of modifying remote:
host: "localhost"
user: "vagrant"
path: "/tmp/some"
behaviour:
uploadOnSave: true
syncDownOnOpen: true
forgetConsole: false
autoHideConsole: true
alwaysSyncAll: false
option:
shell: 'ssh -p 2202 -i .vagrant/machines/default/virtualbox/private_key'
deleteFiles: false
exclude: [
".sync-config.cson"
".git"
"node_modules"
"tmp"
"vendor"
]
|
|
FYI: i pulled your new feature to: |
|
FYI: i reverted the pull request on atom-sync-cygwin, because it caused side effects and bugs in the context menu for sync. see details here: |
Author
|
Cleaning up my Pull Requests tab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you start to follow the idea proposed in #38 and try to use
shellparameter to set path to identity file, there is no way to set it relative to the project directory.This PR makes rsync execute with project directory as cwd so every relative path is now resolved against it. You can still use absolute paths or
~shortcut.